Issue 1227283002: Don't allow package:-URIs as package locations when creating .packages file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1227283002: Don't allow package:-URIs as package locations when creating .packages file. (Closed)

Created:
5 years, 5 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 5 months ago

Reviewers:
pquitslund

Base URL:
https://github.com/dart-lang/package_config.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't allow package:-URIs as package locations when creating .packages file. R=pquitslund@google.com Committed: 00e116222ba9d18b8716acee02e851943ebed00c

Patch Set 1 #

Patch Set 2 : Fix unrelated typo. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
M	lib/discovery.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/packages_file.dart	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

5 years, 5 months ago (2015-07-13 07:19:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
00e116222ba9d18b8716acee02e851943ebed00c (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages