lib/discovery.dart - Issue 1227283002: Don't allow package:-URIs as package locations when creating .packages file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/discovery.dart

Issue 1227283002: Don't allow package:-URIs as package locations when creating .packages file. (Closed) Base URL: https://github.com/dart-lang/package_config.git@master

Patch Set: Fix unrelated typo. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/discovery.dart

diff --git a/lib/discovery.dart b/lib/discovery.dart

index a399395cb74e673be5d23f8500c727d9cc4db453..8e42af79d78fe213b9ec5d1f4ae9d034e99eb0d0 100644

--- a/lib/discovery.dart

+++ b/lib/discovery.dart

@@ -179,7 +179,7 @@ Packages findPackagesFromFile(Uri fileBaseUri) {

/// script.

/// The [nonFileUri] should not be a `file:` URI since the algorithm for

/// finding a package resolution strategy is more elaborate for `file:` URIs.

-/// In that case, use [findPackagesFile].

+/// In that case, use [findPackagesFromFile].

///

/// This function first tries to locate a `.packages` file in the [nonFileUri]

/// directory. If that is not found, it instead assumes a `packages/` directory

« no previous file with comments | « no previous file | lib/packages_file.dart » ('j') | no next file with comments »