Issue 12263018: Fix path tests on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12263018: Fix path tests on windows. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom

Modified:
7 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix path tests on windows. Committed: https://code.google.com/p/dart/source/detail?r=18488

Patch Set 2 : Try escaping the paths in the error message RegExps. #

Total comments: 3

Patch Set 3 : Mention bug in TODO. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -10 lines)			Patch
M	utils/pub/pub.dart	View		1 chunk	+13 lines, -6 lines	0 comments	Download
M	utils/tests/pub/install/path/no_pubspec_test.dart	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	utils/tests/pub/install/path/nonexistent_dir_test.dart	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download
M	utils/tests/pub/install/path/path_is_file_test.dart	View	1 2	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/12263018/diff/2001/utils/pub/pub.dart File utils/pub/pub.dart (right): https://codereview.chromium.org/12263018/diff/2001/utils/pub/pub.dart#newcode248 utils/pub/pub.dart:248: message = error.message; :-/ https://codereview.chromium.org/12263018/diff/2001/utils/tests/pub/install/path/nonexistent_dir_test.dart File utils/tests/pub/install/path/nonexistent_dir_test.dart (right): ...

7 years, 10 months ago (2013-02-13 22:16:39 UTC) #2

Bob Nystrom

7 years, 10 months ago (2013-02-13 22:19:25 UTC) #3

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/12263018/diff/2001/utils/tests/pub/install/pa...
File utils/tests/pub/install/path/nonexistent_dir_test.dart (right):

https://codereview.chromium.org/12263018/diff/2001/utils/tests/pub/install/pa...
utils/tests/pub/install/path/nonexistent_dir_test.dart:29: // stack traces out
of the stderr when we invoke pub.
On 2013/02/13 22:16:39, nweiz wrote:
> Also reference issue 4706 here

Done.