Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: utils/tests/pub/install/path/path_is_file_test.dart

Issue 12263018: Fix path tests on windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Mention bug in TODO. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « utils/tests/pub/install/path/nonexistent_dir_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 import '../../../../../pkg/path/lib/path.dart' as path; 5 import '../../../../../pkg/path/lib/path.dart' as path;
6 6
7 import '../../../../pub/exit_codes.dart' as exit_codes; 7 import '../../../../pub/exit_codes.dart' as exit_codes;
8 import '../../test_pub.dart'; 8 import '../../test_pub.dart';
9 9
10 main() { 10 main() {
11 initConfig(); 11 initConfig();
12 integration('path dependency when path is a file', () { 12 integration('path dependency when path is a file', () {
13 dir('foo', [ 13 dir('foo', [
14 libDir('foo'), 14 libDir('foo'),
15 libPubspec('foo', '0.0.1') 15 libPubspec('foo', '0.0.1')
16 ]).scheduleCreate(); 16 ]).scheduleCreate();
17 17
18 file('dummy.txt', '').scheduleCreate(); 18 file('dummy.txt', '').scheduleCreate();
19 var dummyPath = path.join(sandboxDir, 'dummy.txt'); 19 var dummyPath = path.join(sandboxDir, 'dummy.txt');
20 20
21 dir(appPath, [ 21 dir(appPath, [
22 pubspec({ 22 pubspec({
23 "name": "myapp", 23 "name": "myapp",
24 "dependencies": { 24 "dependencies": {
25 "foo": {"path": dummyPath} 25 "foo": {"path": dummyPath}
26 } 26 }
27 }) 27 })
28 ]).scheduleCreate(); 28 ]).scheduleCreate();
29 29
30 // TODO(rnystrom): The "\" in a Windows path gets treated like a regex
31 // character, so hack escape. A better fix is to use a literal string
32 // instead of a RegExp to validate, but that requires us to move the
33 // stack traces out of the stderr when we invoke pub. See also: #4706.
34 var escapePath = dummyPath.replaceAll(r"\", r"\\");
35
30 schedulePub(args: ['install'], 36 schedulePub(args: ['install'],
31 error: new RegExp("Path dependency for package 'foo' must refer to a " 37 error: new RegExp("Path dependency for package 'foo' must refer to a "
32 "directory, not a file. Was '$dummyPath'."), 38 "directory, not a file. Was '$escapePath'."),
33 exitCode: exit_codes.DATA); 39 exitCode: exit_codes.DATA);
34 }); 40 });
35 } 41 }
OLDNEW
« no previous file with comments | « utils/tests/pub/install/path/nonexistent_dir_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698