Issue 12263010: Optimize stores to ExternalUint8Array and ExternalUint8ClampedArray in the optimizer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12263010: Optimize stores to ExternalUint8Array and ExternalUint8ClampedArray in the optimizer. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Optimize stores to ExternalUint8Array and ExternalUint8ClampedArray in the optimizer. This CL adds support for these two array types to the StoreIndexed instruction. Committed: https://code.google.com/p/dart/source/detail?r=18517

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -29 lines)			Patch
M	runtime/vm/assembler_ia32.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/assembler_x64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		3 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		5 chunks	+28 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		5 chunks	+30 lines, -8 lines	0 comments	Download
M	tests/standalone/byte_array_test.dart	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages