Optimize stores to ExternalUint8Array and ExternalUint8ClampedArray in the optimizer.

runtime/vm/assembler_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/code_generator.h"
 #include "vm/heap.h"
@@ skipping 1607 matching lines @@
   andl(value, Immediate(kObjectAlignment - 1));
   // Compare with the expected bit pattern.
   cmpl(value, Immediate(
       (kNewObjectAlignmentOffset >> 1) + kHeapObjectTag +
       kOldObjectAlignmentOffset + kHeapObjectTag));
   j(NOT_ZERO, no_update, Assembler::kNearJump);
 }
 
 
 void Assembler::StoreIntoObject(Register object,
-                                const FieldAddress& dest,
+                                const Address& dest,
                                 Register value) {
   ASSERT(object != value);
   TraceStoreIntoObject(object, dest, value);
   movl(dest, value);
   Label done;
   StoreIntoObjectFilter(object, value, &done);
   // A store buffer update is required.
   if (value != EAX) pushl(EAX);  // Preserve EAX.
   leal(EAX, dest);
   call(&StubCode::UpdateStoreBufferLabel());
   if (value != EAX) popl(EAX);  // Restore EAX.
   Bind(&done);
 }
 
 
 void Assembler::StoreIntoObjectNoBarrier(Register object,
-                                         const FieldAddress& dest,
+                                         const Address& dest,
                                          Register value) {
   TraceStoreIntoObject(object, dest, value);
   movl(dest, value);
 #if defined(DEBUG)
   Label done;
   pushl(value);
   StoreIntoObjectFilter(object, value, &done);
   Stop("Store buffer update is required");
   Bind(&done);
   popl(value);
 #endif  // defined(DEBUG)
   // No store buffer update.
 }
 
 
 void Assembler::StoreIntoObjectNoBarrier(Register object,
-                                         const FieldAddress& dest,
+                                         const Address& dest,
                                          const Object& value) {
   if (value.IsSmi() || value.InVMHeap()) {
     movl(dest, Immediate(reinterpret_cast<int32_t>(value.raw())));
   } else {
     // No heap trace for an old object store.
     ASSERT(value.IsOld());
     AssemblerBuffer::EnsureCapacity ensured(&buffer_);
     EmitUint8(0xC7);
     EmitOperand(0, dest);
     buffer_.EmitObject(value);
   }
   // No store buffer update.
 }
 
 
 void Assembler::TraceStoreIntoObject(Register object,
-                                     const FieldAddress& dest,
+                                     const Address& dest,
                                      Register value) {
   if (HeapTrace::is_enabled()) {
     pushal();
     EnterCallRuntimeFrame(3 * kWordSize);
     movl(Address(ESP, 0 * kWordSize), object);
     leal(EAX, dest);
     movl(Address(ESP, 1 * kWordSize), EAX);
     movl(Address(ESP, 2 * kWordSize), value);
     CallRuntime(kHeapTraceStoreRuntimeEntry);
     LeaveCallRuntimeFrame();
@@ skipping 378 matching lines @@
 
 const char* Assembler::FpuRegisterName(FpuRegister reg) {
   ASSERT((0 <= reg) && (reg < kNumberOfXmmRegisters));
   return xmm_reg_names[reg];
 }
 
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32