Issue 12263009: - Trust type annotations on fields of HTML classes.

Issue 12263009: - Trust type annotations on fields of HTML classes. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
kasperl, sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Trust type annotations on fields of HTML classes. - Use the native name of a call on an HTML method when possible. - Clean up lookupMember in HType to lookupSingleSelector. Committed: https://code.google.com/p/dart/source/detail?r=18511

Patch Set 1 : #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -22 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/optimize.dart	View	1 2	3 chunks	+22 lines, -19 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1 2	1 chunk	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Stephen noticed I was using the wrong name for native name, so patch set 1 ...

7 years, 10 months ago (2013-02-13 17:50:14 UTC) #2

sra1

lgtm https://codereview.chromium.org/12263009/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/12263009/diff/4001/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1535 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1535: // should check. TODO: Can still inline if ...

7 years, 10 months ago (2013-02-13 19:30:02 UTC) #3

ngeoffray

7 years, 10 months ago (2013-02-14 10:41:28 UTC) #4

Thanks Stephen

https://codereview.chromium.org/12263009/diff/4001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/12263009/diff/4001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1535: // should
check.
On 2013/02/13 19:30:02, sra1 wrote:
> TODO: Can still inline if all the arguments are known to have the right type. 
> Primitive types need to be proven non-null.

Done.

Expand Messages | Collapse Messages