- Trust type annotations on fields of HTML classes.

sdk/lib/_internal/compiler/implementation/ssa/optimize.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 abstract class OptimizationPhase {
   String get name;
   void visitGraph(HGraph graph);
 }
@@ skipping 371 matching lines @@
   HInstruction visitInvokeStatic(HInvokeStatic node) {
     if (isFixedSizeListConstructor(node)) {
       node.guaranteedType = HType.FIXED_ARRAY;
     }
     return node;
   }
 
   HInstruction visitInvokeDynamicMethod(HInvokeDynamicMethod node) {
     if (node.isInterceptorCall) return handleInterceptorCall(node);
     HType receiverType = types[node.receiver];
-    if (receiverType.isExact()) {
-      Element element = receiverType.lookupMember(node.selector.name, compiler);
-      // TODO(ngeoffray): Also fold if it's a getter or variable.
-      if (element != null && element.isFunction()) {
-        if (node.selector.applies(element, compiler)) {
-          FunctionElement method = element;
-          FunctionSignature parameters = method.computeSignature(compiler);
-          if (parameters.optionalParameterCount == 0) {
-            node.element = element;
-          }
-          // TODO(ngeoffray): If the method has optional parameters,
-          // we should pass the default values here.
-        }
+    Element element = receiverType.lookupSingleTarget(node.selector, compiler);
+    // TODO(ngeoffray): Also fold if it's a getter or variable.
+    if (element != null && element.isFunction()) {
+      FunctionElement method = element;
+      FunctionSignature parameters = method.computeSignature(compiler);
+      // TODO(ngeoffray): If the method has optional parameters,
+      // we should pass the default values.
+      if (parameters.optionalParameterCount == 0
+          || parameters.parameterCount == node.selector.argumentCount) {
+        node.element = element;
       }
     }
     return node;
   }
 
   HInstruction visitIntegerCheck(HIntegerCheck node) {
     HInstruction value = node.value;
     if (value.isInteger(types)) return value;
     if (value.isConstant()) {
       HConstant constantInstruction = value;
@@ skipping 181 matching lines @@
       return node;
     }
     HType combinedType = types[value].intersection(types[node], compiler);
     return (combinedType == types[value]) ? value : node;
   }
 
   Element findConcreteFieldForDynamicAccess(HInstruction receiver,
                                             Selector selector) {
     HType receiverType = types[receiver];
     if (!receiverType.isUseful()) return null;
-    if (receiverType.canBeNull()) return null;
     DartType type = receiverType.computeType(compiler);
     if (type == null) return null;
+    if (Elements.isErroneousElement(type.element)) return null;
     return compiler.world.locateSingleField(type, selector);
   }
 
   HInstruction visitFieldGet(HFieldGet node) {
     if (node.element == backend.jsArrayLength) {
       if (node.receiver is HInvokeStatic) {
         // Try to recognize the length getter with input
         // [:new List.fixedLength(int):].
         HInvokeStatic call = node.receiver;
         if (isFixedSizeListConstructor(call)) {
@@ skipping 13 matching lines @@
 
     Modifiers modifiers = field.modifiers;
     bool isFinalOrConst = modifiers.isFinal() || modifiers.isConst();
     if (!compiler.resolverWorld.hasInvokedSetter(field, compiler)) {
       // If no setter is ever used for this field it is only initialized in the
       // initializer list.
       isFinalOrConst = true;
     }
     HFieldGet result = new HFieldGet(
         field, node.inputs[0], isAssignable: !isFinalOrConst);
-    HType type = backend.optimisticFieldType(field);
-    if (type != null) {
-      result.guaranteedType = type;
-      backend.registerFieldTypesOptimization(
-          work.element, field, result.guaranteedType);
+
+    if (field.getEnclosingClass().isNative()) {
+      result.guaranteedType =
+          new HType.subtype(field.computeType(compiler), compiler);
+    } else {
+      HType type = backend.optimisticFieldType(field);
+      if (type != null) {
+        backend.registerFieldTypesOptimization(
+            work.element, field, result.guaranteedType);
+        result.guaranteedType = type;
+      }
     }
     return result;
   }
 
   HInstruction visitInvokeDynamicSetter(HInvokeDynamicSetter node) {
     if (node.isInterceptorCall) return handleInterceptorCall(node);
 
     Element field =
         findConcreteFieldForDynamicAccess(node.receiver, node.selector);
     if (field == null || !field.isAssignable()) return node;
@@ skipping 885 matching lines @@
     HBasicBlock block = user.block;
     block.addAfter(user, interceptor);
     block.rewrite(user, interceptor);
     block.remove(user);
 
     // The interceptor will be removed in the dead code elimination
     // phase. Note that removing it here would not work because of how
     // the [visitBasicBlock] is implemented.
   }
 }