Issue 12262048: Renaming Element.dataAttributes to Element.dataset.

Issue 12262048: Renaming Element.dataAttributes to Element.dataset. (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Renaming Element.dataAttributes to Element.dataset. Element.dataset is the DOM version of the API, so we should have ours named the same. Opened bug #8545 that we should optimize Element.dataset to use the native functionality if present. BUG=5963 Committed: https://code.google.com/p/dart/source/detail?r=18533

Patch Set 1 #

Total comments: 1

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -62 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	tests/html/element_test.dart	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	tests/html/htmlelement_test.dart	View	2 chunks	+27 lines, -27 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+6 lines, -6 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jacob

lgtm https://codereview.chromium.org/12262048/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate File tools/dom/templates/html/impl/impl_Element.darttemplate (left): https://codereview.chromium.org/12262048/diff/1/tools/dom/templates/html/impl/impl_Element.darttemplate#oldcode677 tools/dom/templates/html/impl/impl_Element.darttemplate:677: */ we should think about whether the regular ...

7 years, 10 months ago (2013-02-14 18:16:36 UTC) #2

blois

7 years, 10 months ago (2013-02-14 19:06:05 UTC) #3

On 2013/02/14 18:16:36, Jacob wrote:
> lgtm
> 
>
https://codereview.chromium.org/12262048/diff/1/tools/dom/templates/html/impl...
> File tools/dom/templates/html/impl/impl_Element.darttemplate (left):
> 
>
https://codereview.chromium.org/12262048/diff/1/tools/dom/templates/html/impl...
> tools/dom/templates/html/impl/impl_Element.darttemplate:677: */
> we should think about whether the regular browser dataset implementation
should
> be used on modern browsers rather than the existing polyfill.

Yeah, I had opened bug 8545 for that.

It's not a simple fallback as we need to fix up aspects of the map in our
Dart2JS conversion.

Expand Messages | Collapse Messages