Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12262048: Renaming Element.dataAttributes to Element.dataset. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 5499b22cfaa3c634021f5f0c715f72b505882a14..f4f9de1c083215a2c8b0dadb52e8fd550c406d6b 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -669,20 +669,20 @@ $(ANNOTATIONS)abstract class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
*
* Would be accessed in Dart as:
*
- * var value = element.dataAttributes['myRandomValue'];
+ * var value = element.dataset['myRandomValue'];
*
* See also:
*
* * [Custom data attributes](http://www.w3.org/TR/html5/global-attributes.html#custom-data-attribute)
*/
Jacob 2013/02/14 18:16:36 we should think about whether the regular browser
- Map<String, String> get dataAttributes =>
+ Map<String, String> get dataset =>
new _DataAttributeMap(attributes);
- void set dataAttributes(Map<String, String> value) {
- final dataAttributes = this.dataAttributes;
- dataAttributes.clear();
+ void set dataset(Map<String, String> value) {
+ final data = this.dataset;
+ data.clear();
for (String key in value.keys) {
- dataAttributes[key] = value[key];
+ data[key] = value[key];
}
}
« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698