Issue 12260008: Reapply r18377 it was reverted due to the unrelated bug it surfaced.

Issue 12260008: Reapply r18377 it was reverted due to the unrelated bug it surfaced. (Closed)

Created:
7 years, 10 months ago by Vyacheslav Egorov (Google)

Modified:
7 years, 10 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply r18377 it was reverted due to the unrelated bug it surfaced. Remove SminessPropagator and FlowGraphTypePropagator and all associated infrastructure and fields. Replace multiple fields (result_cid_, propagated_cid_, propagated_type_, reaching_cid_) with a single field of type CompileType which represents an element of type analysis lattice and incorporates information about: value's nullability, concrete class id and abstract super type. This ensures that propagated cid and type are always in sync and complement each other Implement a new FlowGraphPropagator that propagates types over the CompileType-lattice. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=18456

Patch Set 1 #

Total comments: 4

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1188 lines, -1551 lines)			Patch
M	runtime/vm/compiler.cc	View	3 chunks	+15 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	13 chunks	+18 lines, -451 lines	0 comments	Download
A	runtime/vm/flow_graph_type_propagator.h	View	1 chunk	+77 lines, -0 lines	4 comments	Download
A	runtime/vm/flow_graph_type_propagator.cc	View	1 chunk	+734 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	9 chunks	+45 lines, -29 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	114 chunks	+210 lines, -277 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	15 chunks	+30 lines, -714 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	7 chunks	+16 lines, -15 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	6 chunks	+12 lines, -13 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/12260008/diff/1/runtime/vm/flow_graph_type_propagator.h File runtime/vm/flow_graph_type_propagator.h (right): https://codereview.chromium.org/12260008/diff/1/runtime/vm/flow_graph_type_propagator.h#newcode54 runtime/vm/flow_graph_type_propagator.h:54: public: struct has default public members, so you ...

7 years, 10 months ago (2013-02-13 15:39:18 UTC) #2

Vyacheslav Egorov (Google)

7 years, 10 months ago (2013-02-13 16:18:46 UTC) #3

https://codereview.chromium.org/12260008/diff/1/runtime/vm/flow_graph_type_pr...
File runtime/vm/flow_graph_type_propagator.h (right):

https://codereview.chromium.org/12260008/diff/1/runtime/vm/flow_graph_type_pr...
runtime/vm/flow_graph_type_propagator.h:54: public:
On 2013/02/13 15:39:18, Florian Schneider wrote:
> struct has default public members, so you could save a line here.

changed to class.

https://codereview.chromium.org/12260008/diff/1/runtime/vm/flow_graph_type_pr...
runtime/vm/flow_graph_type_propagator.h:56: RollbackEntry()
On 2013/02/13 15:39:18, Florian Schneider wrote:
> Strange line breaks. Maybe all in one line?

I wanted it to match the next constructor.

Expand Messages | Collapse Messages