runtime/vm/flow_graph_builder.cc - Issue 12260008: Reapply r18377 it was reverted due to the unrelated bug it surfaced.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 12260008: Reapply r18377 it was reverted due to the unrelated bug it surfaced. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_builder.cc

diff --git a/runtime/vm/flow_graph_builder.cc b/runtime/vm/flow_graph_builder.cc

index 236c4d9dd7ea7069257f6131573bb0871530638f..ce2e218b5d125153590e02a7581e165dcb211f26 100644

--- a/runtime/vm/flow_graph_builder.cc

+++ b/runtime/vm/flow_graph_builder.cc

@@ -762,12 +762,7 @@ bool EffectGraphVisitor::CanSkipTypeCheck(intptr_t token_pos,

return false;

}

- // Propagated types are not set yet.

- // More checks will possibly be eliminated during type propagation.

- bool is_null, is_instance;

- const bool eliminated =

- (value->CanComputeIsNull(&is_null) && is_null) ||

- (value->CanComputeIsInstanceOf(dst_type, &is_instance) && is_instance);

+ const bool eliminated = value->Type()->IsAssignableTo(dst_type);

if (FLAG_trace_type_check_elimination) {

FlowGraphPrinter::PrintTypeCheck(owner()->parsed_function(),

token_pos,

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | runtime/vm/flow_graph_type_propagator.h » ('J')