Get rid of old redundant methods in io.dart.

Get rid of old redundant methods in io.dart.

Now that we have pkg/path, we can ditch the old methods in io.dart
that do the same thing.

Committed: https://code.google.com/p/dart/source/detail?r=18500

[Bob Nystrom, 2013-02-13 22:09:51]

Now that we have pkg/path, start using it more!

Eventually, I'd like to move towards only using strings throughout pub for file
paths and encapsulating all references to File and Directory inside io.dart.

[nweiz, 2013-02-14 00:10:37]

LGTM

I'd like to see a more thorough move to never pass around File and Directory
objects outside of io.dart, but this is a fine first step.

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart#newcode28
utils/pub/io.dart:28: String join(part1, [part2, part3, part4, part5, part6,
part7, part8]) {
Can we get rid of this?

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart#newcode37
utils/pub/io.dart:37: List<String> splitPath(entry) =>
path.split(_getPath(entry));
Can we get rid of this?

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart#newcode41
utils/pub/io.dart:41: bool isBeneath(entry, dir) {
Since this just calls path methods now, we should mark these as Strings.

[Bob Nystrom, 2013-02-14 01:14:19]

Thanks!

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart#newcode28
utils/pub/io.dart:28: String join(part1, [part2, part3, part4, part5, part6,
part7, part8]) {
On 2013/02/14 00:10:37, nweiz wrote:
> Can we get rid of this?

That will be a bit more invasive, so I figured I'd do that in another patch. I
like doing things incrementally.

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart#newcode37
utils/pub/io.dart:37: List<String> splitPath(entry) =>
path.split(_getPath(entry));
On 2013/02/14 00:10:37, nweiz wrote:
> Can we get rid of this?

Done.

https://codereview.chromium.org/12255016/diff/1/utils/pub/io.dart#newcode41
utils/pub/io.dart:41: bool isBeneath(entry, dir) {
On 2013/02/14 00:10:37, nweiz wrote:
> Since this just calls path methods now, we should mark these as Strings.

Done.