OLD | NEW |
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file | 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file |
2 // for details. All rights reserved. Use of this source code is governed by a | 2 // for details. All rights reserved. Use of this source code is governed by a |
3 // BSD-style license that can be found in the LICENSE file. | 3 // BSD-style license that can be found in the LICENSE file. |
4 | 4 |
5 library directory_validator; | 5 library directory_validator; |
6 | 6 |
7 import 'dart:async'; | 7 import 'dart:async'; |
8 | 8 |
| 9 import '../../../pkg/path/lib/path.dart' as path; |
| 10 |
9 import '../entrypoint.dart'; | 11 import '../entrypoint.dart'; |
10 import '../io.dart'; | 12 import '../io.dart'; |
11 import '../utils.dart'; | 13 import '../utils.dart'; |
12 import '../validator.dart'; | 14 import '../validator.dart'; |
13 | 15 |
14 /// A validator that validates a package's top-level directories. | 16 /// A validator that validates a package's top-level directories. |
15 class DirectoryValidator extends Validator { | 17 class DirectoryValidator extends Validator { |
16 DirectoryValidator(Entrypoint entrypoint) | 18 DirectoryValidator(Entrypoint entrypoint) |
17 : super(entrypoint); | 19 : super(entrypoint); |
18 | 20 |
19 static final _PLURAL_NAMES = ["tools", "tests", "docs", "examples"]; | 21 static final _PLURAL_NAMES = ["tools", "tests", "docs", "examples"]; |
20 | 22 |
21 Future validate() { | 23 Future validate() { |
22 return listDir(entrypoint.root.dir).then((dirs) { | 24 return listDir(entrypoint.root.dir).then((dirs) { |
23 for (var dir in dirs) { | 25 for (var dir in dirs) { |
24 if (!dirExists(dir)) continue; | 26 if (!dirExists(dir)) continue; |
25 | 27 |
26 dir = basename(dir); | 28 dir = path.basename(dir); |
27 if (_PLURAL_NAMES.contains(dir)) { | 29 if (_PLURAL_NAMES.contains(dir)) { |
28 // Cut off the "s" | 30 // Cut off the "s" |
29 var singularName = dir.substring(0, dir.length - 1); | 31 var singularName = dir.substring(0, dir.length - 1); |
30 warnings.add('Rename the top-level "$dir" directory to ' | 32 warnings.add('Rename the top-level "$dir" directory to ' |
31 '"$singularName".\n' | 33 '"$singularName".\n' |
32 'The Pub layout convention is to use singular directory ' | 34 'The Pub layout convention is to use singular directory ' |
33 'names.\n' | 35 'names.\n' |
34 'Plural names won\'t be correctly identified by Pub and other ' | 36 'Plural names won\'t be correctly identified by Pub and other ' |
35 'tools.'); | 37 'tools.'); |
36 } | 38 } |
37 | 39 |
38 if (dir.contains(new RegExp(r"^samples?$"))) { | 40 if (dir.contains(new RegExp(r"^samples?$"))) { |
39 warnings.add('Rename the top-level "$dir" directory to "example".\n' | 41 warnings.add('Rename the top-level "$dir" directory to "example".\n' |
40 'This allows Pub to find your examples and create "packages" ' | 42 'This allows Pub to find your examples and create "packages" ' |
41 'directories for them.\n'); | 43 'directories for them.\n'); |
42 } | 44 } |
43 } | 45 } |
44 }); | 46 }); |
45 } | 47 } |
46 } | 48 } |
OLD | NEW |