Issue 1222863003: Make frequent type checks (instanceof) faster by adding dedicated instanceof methods; improves dart…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1222863003: Make frequent type checks (instanceof) faster by adding dedicated instanceof methods; improves dart… (Closed)

Created:
5 years, 5 months ago by srdjan

Modified:
5 years, 5 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make frequent type checks (instanceof) faster by adding dedicated instanceof methods; improves dart2js startup There is a possibility of adding intrinsics for all new instanceOf methods; my measurements did not show any benefits, therefore they were removed from this CL. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/5711c13f690b9788f6b3ca6064028849eeb0b4da

Patch Set 1 #

Patch Set 2 : c #

Patch Set 3 : flag #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+159 lines, -9 lines)			Patch
M	runtime/lib/object.cc	View		1 chunk	+60 lines, -0 lines	0 comments	Download
M	runtime/lib/object_patch.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/bootstrap_natives.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	1 2	2 chunks	+40 lines, -3 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		1 chunk	+34 lines, -6 lines	0 comments	Download
M	runtime/vm/object.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/symbols.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

srdjan

Also disabled the optimization if --warn_on_javascript_compatibility.

5 years, 5 months ago (2015-07-07 17:12:40 UTC) #4

srdjan

5 years, 5 months ago (2015-07-07 17:20:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
5711c13f690b9788f6b3ca6064028849eeb0b4da (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages