Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Side by Side Diff: runtime/lib/object_patch.dart

Issue 1222863003: Make frequent type checks (instanceof) faster by adding dedicated instanceof methods; improves dart… (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: flag Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 patch class Object { 5 patch class Object {
6 6
7 // The VM has its own implementation of equals. 7 // The VM has its own implementation of equals.
8 bool operator ==(other) native "Object_equals"; 8 bool operator ==(other) native "Object_equals";
9 9
10 // Helpers used to implement hashCode. If a hashCode is used, we remember it 10 // Helpers used to implement hashCode. If a hashCode is used, we remember it
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 /* patch */ Type get runtimeType native "Object_runtimeType"; 52 /* patch */ Type get runtimeType native "Object_runtimeType";
53 53
54 // Call this function instead of inlining instanceof, thus collecting 54 // Call this function instead of inlining instanceof, thus collecting
55 // type feedback and reducing code size of unoptimized code. 55 // type feedback and reducing code size of unoptimized code.
56 bool _instanceOf(instantiator, 56 bool _instanceOf(instantiator,
57 instantiator_type_arguments, 57 instantiator_type_arguments,
58 type, 58 type,
59 bool negate) 59 bool negate)
60 native "Object_instanceOf"; 60 native "Object_instanceOf";
61 61
62 bool _instanceOfDouble(bool negate) native "Object_instanceOfDouble";
63 bool _instanceOfNum(bool negate) native "Object_instanceOfNum";
64 bool _instanceOfInt(bool negate) native "Object_instanceOfInt";
65 bool _instanceOfSmi(bool negate) native "Object_instanceOfSmi";
66 bool _instanceOfString(bool negate) native "Object_instanceOfString";
67
62 // Call this function instead of inlining 'as', thus collecting type 68 // Call this function instead of inlining 'as', thus collecting type
63 // feedback. Returns receiver. 69 // feedback. Returns receiver.
64 _as(instantiator, instantiator_type_arguments, type) native "Object_as"; 70 _as(instantiator, instantiator_type_arguments, type) native "Object_as";
65 71
66 static _symbolMapToStringMap(Map<Symbol, dynamic> map) { 72 static _symbolMapToStringMap(Map<Symbol, dynamic> map) {
67 var result = new Map<String, dynamic>(); 73 var result = new Map<String, dynamic>();
68 map.forEach((Symbol key, value) { 74 map.forEach((Symbol key, value) {
69 result[internal.Symbol.getName(key)] = value; 75 result[internal.Symbol.getName(key)] = value;
70 }); 76 });
71 return result; 77 return result;
72 } 78 }
73 79
74 _leftShiftWithMask32(count, mask) { 80 _leftShiftWithMask32(count, mask) {
75 return (this << count) & mask; 81 return (this << count) & mask;
76 } 82 }
77 } 83 }
OLDNEW
« no previous file with comments | « runtime/lib/object.cc ('k') | runtime/vm/bootstrap_natives.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698