Issue 12225049: Add optimized loads from ExternalUint8ClampedArrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12225049: Add optimized loads from ExternalUint8ClampedArrays. (Closed)

Created:
7 years, 10 months ago by Florian Schneider

Modified:
7 years, 10 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add optimized loads from ExternalUint8ClampedArrays. The generated code is exactly the same as for ExternalUint8Array. TEST=tests/standalone/byte_array_test.dart Committed: https://code.google.com/p/dart/source/detail?r=18183

Patch Set 1 #

Patch Set 2 : addressed previous dbc #

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -11 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	6 chunks	+8 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	6 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Please take a look. Also addressed your comments to my previous CL.

7 years, 10 months ago (2013-02-06 17:43:49 UTC) #1

srdjan

7 years, 10 months ago (2013-02-06 18:44:00 UTC) #2

LGTM!
Do we already have tests for optimized uin8 clamped external arrays?
This will bring a significant speedup to all Canvas data operations!!!

Expand Messages | Collapse Messages