Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 12225049: Add optimized loads from ExternalUint8ClampedArrays. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intermediate_language_x64.cc
===================================================================
--- runtime/vm/intermediate_language_x64.cc (revision 18176)
+++ runtime/vm/intermediate_language_x64.cc (working copy)
@@ -970,6 +970,7 @@
case kUint8ArrayCid:
case kUint8ClampedArrayCid:
case kExternalUint8ArrayCid:
+ case kExternalUint8ClampedArrayCid:
case kInt16ArrayCid:
case kUint16ArrayCid:
case kOneByteStringCid:
@@ -992,6 +993,7 @@
case kUint8ArrayCid:
case kUint8ClampedArrayCid:
case kExternalUint8ArrayCid:
+ case kExternalUint8ClampedArrayCid:
case kInt16ArrayCid:
case kUint16ArrayCid:
case kOneByteStringCid:
@@ -1034,7 +1036,8 @@
Register array = locs()->in(0).reg();
Location index = locs()->in(1);
- if (class_id() == kExternalUint8ArrayCid) {
+ if ((class_id() == kExternalUint8ArrayCid) ||
+ (class_id() == kExternalUint8ClampedArrayCid)) {
Register result = locs()->out().reg();
Address element_address = index.IsRegister()
? FlowGraphCompiler::ExternalElementAddressForRegIndex(
@@ -1064,7 +1067,7 @@
Smi::Cast(index.constant()).Value());
if (representation() == kUnboxedDouble) {
- if (index_scale() == 1 && index.IsRegister()) {
+ if ((index_scale() == 1) && index.IsRegister()) {
__ SmiUntag(index.reg());
}
@@ -1079,13 +1082,13 @@
__ movsd(result, element_address);
}
- if (index_scale() == 1 && index.IsRegister()) {
+ if ((index_scale() == 1) && index.IsRegister()) {
__ SmiTag(index.reg()); // Re-tag.
}
return;
}
- if (index_scale() == 1 && index.IsRegister()) {
+ if ((index_scale() == 1) && index.IsRegister()) {
__ SmiUntag(index.reg());
}
Register result = locs()->out().reg();
@@ -1123,7 +1126,7 @@
__ movq(result, element_address);
break;
}
- if (index_scale() == 1 && index.IsRegister()) {
+ if ((index_scale() == 1) && index.IsRegister()) {
__ SmiTag(index.reg()); // Re-tag.
}
}
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698