Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1222433003: Invalidate both hints and lints on incremental resolution. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Invalidate both hints and lints on incremental resolution. We don't have new LINTS result descriptor yet, once we have, we need to update the new AnalysisContext implementation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5bcd357802dfbb194245f16bcdfe7a574556e221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -39 lines) Patch
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 5 chunks +10 lines, -35 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-06-30 21:02:22 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-30 21:35:29 UTC) #2
scheglov
5 years, 5 months ago (2015-06-30 22:31:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5bcd357802dfbb194245f16bcdfe7a574556e221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698