Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Side by Side Diff: pkg/analyzer/lib/src/generated/engine.dart

Issue 1222433003: Invalidate both hints and lints on incremental resolution. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 // This code was auto-generated, is not intended to be edited, and is subject to 5 // This code was auto-generated, is not intended to be edited, and is subject to
6 // significant change. Please see the README file for more information. 6 // significant change. Please see the README file for more information.
7 7
8 library engine; 8 library engine;
9 9
10 import 'dart:async'; 10 import 'dart:async';
(...skipping 2204 matching lines...) Expand 10 before | Expand all | Expand 10 after
2215 @override 2215 @override
2216 void invalidateLibraryHints(Source librarySource) { 2216 void invalidateLibraryHints(Source librarySource) {
2217 SourceEntry sourceEntry = _cache.get(librarySource); 2217 SourceEntry sourceEntry = _cache.get(librarySource);
2218 if (sourceEntry is! DartEntry) { 2218 if (sourceEntry is! DartEntry) {
2219 return; 2219 return;
2220 } 2220 }
2221 DartEntry dartEntry = sourceEntry; 2221 DartEntry dartEntry = sourceEntry;
2222 // Prepare sources to invalidate hints in. 2222 // Prepare sources to invalidate hints in.
2223 List<Source> sources = <Source>[librarySource]; 2223 List<Source> sources = <Source>[librarySource];
2224 sources.addAll(dartEntry.getValue(DartEntry.INCLUDED_PARTS)); 2224 sources.addAll(dartEntry.getValue(DartEntry.INCLUDED_PARTS));
2225 // Invalidate hints. 2225 // Invalidate hints and lints.
2226 for (Source source in sources) { 2226 for (Source source in sources) {
2227 DartEntry dartEntry = _cache.get(source); 2227 DartEntry dartEntry = _cache.get(source);
2228 if (dartEntry.getStateInLibrary(DartEntry.HINTS, librarySource) == 2228 if (dartEntry.getStateInLibrary(DartEntry.HINTS, librarySource) ==
2229 CacheState.VALID) { 2229 CacheState.VALID) {
2230 dartEntry.setStateInLibrary( 2230 dartEntry.setStateInLibrary(
2231 DartEntry.HINTS, librarySource, CacheState.INVALID); 2231 DartEntry.HINTS, librarySource, CacheState.INVALID);
2232 } 2232 }
2233 if (dartEntry.getStateInLibrary(DartEntry.LINTS, librarySource) ==
2234 CacheState.VALID) {
2235 dartEntry.setStateInLibrary(
2236 DartEntry.LINTS, librarySource, CacheState.INVALID);
2237 }
2233 } 2238 }
2234 } 2239 }
2235 2240
2236 @override 2241 @override
2237 bool isClientLibrary(Source librarySource) { 2242 bool isClientLibrary(Source librarySource) {
2238 SourceEntry sourceEntry = _getReadableSourceEntry(librarySource); 2243 SourceEntry sourceEntry = _getReadableSourceEntry(librarySource);
2239 if (sourceEntry is DartEntry) { 2244 if (sourceEntry is DartEntry) {
2240 DartEntry dartEntry = sourceEntry; 2245 DartEntry dartEntry = sourceEntry;
2241 return dartEntry.getValue(DartEntry.IS_CLIENT) && 2246 return dartEntry.getValue(DartEntry.IS_CLIENT) &&
2242 dartEntry.getValue(DartEntry.IS_LAUNCHABLE); 2247 dartEntry.getValue(DartEntry.IS_LAUNCHABLE);
(...skipping 9591 matching lines...) Expand 10 before | Expand all | Expand 10 after
11834 PendingFuture pendingFuture = 11839 PendingFuture pendingFuture =
11835 new PendingFuture<T>(_context, source, computeValue); 11840 new PendingFuture<T>(_context, source, computeValue);
11836 if (!pendingFuture.evaluate(sourceEntry)) { 11841 if (!pendingFuture.evaluate(sourceEntry)) {
11837 _context._pendingFutureSources 11842 _context._pendingFutureSources
11838 .putIfAbsent(source, () => <PendingFuture>[]) 11843 .putIfAbsent(source, () => <PendingFuture>[])
11839 .add(pendingFuture); 11844 .add(pendingFuture);
11840 } 11845 }
11841 return pendingFuture.future; 11846 return pendingFuture.future;
11842 } 11847 }
11843 } 11848 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/incremental_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698