Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 12224128: Pump the event queue manually rather than using a timer. (Closed)

Created:
7 years, 10 months ago by nweiz
Modified:
7 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Pump the event queue manually rather than using a timer. Hopefully this will be less flaky than timer-based tests. Committed: https://code.google.com/p/dart/source/detail?r=18420

Patch Set 1 #

Patch Set 2 : Get rid of one more sleep call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -71 lines) Patch
M pkg/scheduled_test/lib/src/utils.dart View 1 chunk +0 lines, -45 lines 0 comments Download
M pkg/scheduled_test/test/metatest.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/scheduled_test/test/scheduled_test_test.dart View 1 13 chunks +35 lines, -26 lines 0 comments Download
A pkg/scheduled_test/test/utils.dart View 1 chunk +87 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
nweiz
7 years, 10 months ago (2013-02-12 21:07:41 UTC) #1
Bob Nystrom
7 years, 10 months ago (2013-02-12 21:49:01 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698