Issue 12224024: Generate first ARM assembler test and execute (simulate) it.

Issue 12224024: Generate first ARM assembler test and execute (simulate) it. (Closed)

Created:
7 years, 10 months ago by regis

Modified:
7 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Generate first ARM assembler test and execute (simulate) it. RFC: First draft showing how generated ARM code accesses GC'ed objects and accesses patched call targets. Committed: https://code.google.com/p/dart/source/detail?r=18200

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -25 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_arm.h	View	1	4 chunks	+17 lines, -7 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1	5 chunks	+70 lines, -10 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/assembler_mips_test.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/constants_arm.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download
M	runtime/vm/simulator_mips.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_mips.cc	View	1	1 chunk	+26 lines, -1 line	0 comments	Download
M	runtime/vm/unit_test.h	View	1	2 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.cc#newcode1183 runtime/vm/assembler_arm.cc:1183: AddConstant(LR, CP, offset12_hi); As discussed, ...

7 years, 10 months ago (2013-02-06 23:33:50 UTC) #2

regis

7 years, 10 months ago (2013-02-07 00:53:24 UTC) #3

Thanks!

https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.cc#n...
runtime/vm/assembler_arm.cc:1183: AddConstant(LR, CP, offset12_hi);
On 2013/02/06 23:33:50, Ivan Posva wrote:
> As discussed, please do not use macros here as they will make it really hard
to
> patch.

Done.

https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.cc#n...
runtime/vm/assembler_arm.cc:1527: for (int i = 0; i < objects_.Length(); i++) {
On 2013/02/06 23:33:50, Ivan Posva wrote:
> As discussed we should just return the offset here and deal with the indexing
> and offsetting at the use.

Done.

https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.cc#n...
runtime/vm/assembler_arm.cc:1548: return /*kCodeObjectsHeaderSize +*/
4*(objects_.Length() - 1);
On 2013/02/06 23:33:50, Ivan Posva wrote:
> ditto.

Done.

https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.h
File runtime/vm/assembler_arm.h (right):

https://codereview.chromium.org/12224024/diff/1/runtime/vm/assembler_arm.h#ne...
runtime/vm/assembler_arm.h:267:
objects_(GrowableObjectArray::ZoneHandle(GrowableObjectArray::New())),
On 2013/02/06 23:33:50, Ivan Posva wrote:
> object_pool_

Done. Also changed from ZoneHandle to Handle.

https://codereview.chromium.org/12224024/diff/1/runtime/vm/unit_test.h
File runtime/vm/unit_test.h (right):

https://codereview.chromium.org/12224024/diff/1/runtime/vm/unit_test.h#newcod...
runtime/vm/unit_test.h:132: #if defined(HOST_ARCH_ARM) ||
defined(HOST_ARCH_MIPS)
On 2013/02/06 23:33:50, Ivan Posva wrote:
> This whole section is only valid when TARGET_ARCH_ARM || TARGET_ARCH_MIPS.

Done.

Expand Messages | Collapse Messages