Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 12223036: Always explicitely give a type to HInvokeStatic, and make the literal map know it's a map. (Closed)

Created:
7 years, 10 months ago by ngeoffray
Modified:
7 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

Always explicitely give a type to HInvokeStatic, and make the literal map know it's a map. Committed: https://code.google.com/p/dart/source/detail?r=18210

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -37 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/native_handler.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 19 chunks +58 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/nodes.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
A tests/compiler/dart2js/literal_map_test.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ngeoffray
Fixes issue https://code.google.com/p/dart/issues/detail?id=8204.
7 years, 10 months ago (2013-02-07 09:03:47 UTC) #1
Johnni Winther
7 years, 10 months ago (2013-02-07 09:17:09 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698