Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3852)

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart

Issue 12223036: Always explicitely give a type to HInvokeStatic, and make the literal map know it's a map. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/ssa/nodes.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (revision 18207)
+++ sdk/lib/_internal/compiler/implementation/ssa/nodes.dart (working copy)
@@ -1441,8 +1441,8 @@
class HInvokeStatic extends HInvoke {
/** The first input must be the target. */
- HInvokeStatic(inputs, [HType knownType = HType.UNKNOWN]) : super(inputs) {
- guaranteedType = knownType;
+ HInvokeStatic(inputs, HType type) : super(inputs) {
+ guaranteedType = type;
}
toString() => 'invoke static: ${element.name}';
@@ -1454,7 +1454,7 @@
class HInvokeSuper extends HInvokeStatic {
final bool isSetter;
- HInvokeSuper(inputs, {this.isSetter: false}) : super(inputs);
+ HInvokeSuper(inputs, {this.isSetter: false}) : super(inputs, HType.UNKNOWN);
toString() => 'invoke super: ${element.name}';
accept(HVisitor visitor) => visitor.visitInvokeSuper(this);
« no previous file with comments | « sdk/lib/_internal/compiler/implementation/ssa/builder.dart ('k') | tests/compiler/dart2js/literal_map_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698