Issue 12223004: Allow private selectors to be typed, and fix ClassElement.isSubclassOf to take patches into account.

Issue 12223004: Allow private selectors to be typed, and fix ClassElement.isSubclassOf to take patches into account. (Closed)

Created:
7 years, 10 months ago by ngeoffray

Modified:
7 years, 10 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow private selectors to be typed, and fix ClassElement.isSubclassOf to take patches into account. Committed: https://code.google.com/p/dart/source/detail?r=18126

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/patch_test.dart	View	1 2	2 chunks	+18 lines, -0 lines	0 comments	Download
A	tests/language/private_selector_lib.dart	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	tests/language/private_selector_test.dart	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Thanks Johnni. I also added a small fix (use the selector instead of the element) ...

7 years, 10 months ago (2013-02-05 10:48:09 UTC) #3

Johnni Winther

Still LGTM https://codereview.chromium.org/12223004/diff/8001/sdk/lib/_internal/compiler/implementation/universe/universe.dart File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right): https://codereview.chromium.org/12223004/diff/8001/sdk/lib/_internal/compiler/implementation/universe/universe.dart#newcode437 sdk/lib/_internal/compiler/implementation/universe/universe.dart:437: if (resolved == null) return ; Why ...

7 years, 10 months ago (2013-02-05 11:07:35 UTC) #4

ngeoffray

7 years, 10 months ago (2013-02-05 11:17:30 UTC) #5

Thanks Johnni.

https://codereview.chromium.org/12223004/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/12223004/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:437: if
(resolved == null) return ;
On 2013/02/05 11:07:35, Johnni Winther wrote:
> Why not return false here?

Bad edit. Thanks for spotting it!

Expand Messages | Collapse Messages