sdk/lib/_internal/compiler/implementation/ssa/codegen.dart - Issue 12223004: Allow private selectors to be typed, and fix ClassElement.isSubclassOf to take patches into account.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

Issue 12223004: Allow private selectors to be typed, and fix ClassElement.isSubclassOf to take patches into account. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/elements/modelx.dart ('k') | sdk/lib/_internal/compiler/implementation/universe/universe.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/ssa/codegen.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (revision 18125)

+++ sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (working copy)

@@ -1560,8 +1560,6 @@

Selector getOptimizedSelectorFor(HInvokeDynamic node,

Selector defaultSelector) {

- // TODO(4434): For private members we need to use the untyped selector.

- if (defaultSelector.name.isPrivate()) return defaultSelector;

// TODO(ngeoffray): Type intercepted calls.

if (node.isInterceptorCall) return defaultSelector;

// If [JSInvocationMirror.invokeOn] has been called, we must not create a