Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also (Closed)

Created:
7 years, 10 months ago by Emily Fortuna
Modified:
7 years, 10 months ago
Reviewers:
floitsch, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also Stream-and-future-ified some of the Window methods that used to take callbacks. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18475

Patch Set 1 : #

Total comments: 60

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -408 lines) Patch
M samples/calculator/calculator.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M samples/dartcombat/setup.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/isolate_html/isolate_sample.dart View 1 1 chunk +2 lines, -4 lines 0 comments Download
M samples/swarm/App.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/SwarmViews.dart View 1 1 chunk +6 lines, -6 lines 0 comments Download
M samples/swarm/Views.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/base/AnimationScheduler.dart View 1 5 chunks +15 lines, -13 lines 0 comments Download
M samples/swarm/swarm_ui_lib/base/DomWrapper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/base/base.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Scrollbar.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/ConveyorView.dart View 2 chunks +5 lines, -8 lines 0 comments Download
M samples/tests/samples/dartcombat/dartcombat_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M samples/tests/samples/lib/layout/layout_test.dart View 1 2 chunks +4 lines, -3 lines 0 comments Download
M samples/tests/samples/swarm/swarm_test.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M samples/third_party/dromaeo/Dromaeo.dart View 1 chunk +1 line, -0 lines 0 comments Download
M samples/third_party/dromaeo/tests/RunnerSuite.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +63 lines, -42 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 4 chunks +28 lines, -23 lines 0 comments Download
M tests/benchmark_smoke/benchmark_base.dart View 6 chunks +12 lines, -11 lines 0 comments Download
M tests/benchmark_smoke/benchmark_lib.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/async_window_test.dart View 1 chunk +21 lines, -18 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/history_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/js_interop_3_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/html/js_interop_4_test.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/html/microtask_test.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/transition_event_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/html/window_open_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 chunk +4 lines, -0 lines 0 comments Download
D tools/dom/templates/html/dart2js/impl_Window.darttemplate View 1 chunk +0 lines, -173 lines 0 comments Download
D tools/dom/templates/html/dartium/impl_Window.darttemplate View 1 chunk +0 lines, -47 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_Window.darttemplate View 1 4 chunks +77 lines, -26 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Emily Fortuna
Added Florian for switching to using timer.
7 years, 10 months ago (2013-02-13 00:49:06 UTC) #1
blois
https://codereview.chromium.org/12218131/diff/2001/samples/calculator/calculator.dart File samples/calculator/calculator.dart (right): https://codereview.chromium.org/12218131/diff/2001/samples/calculator/calculator.dart#newcode328 samples/calculator/calculator.dart:328: new Timer(const Duration(milliseconds: 80), Not for this CL, but ...
7 years, 10 months ago (2013-02-13 03:09:24 UTC) #2
floitsch
LGTM, but wait for Pete's ok too. https://codereview.chromium.org/12218131/diff/2001/samples/calculator/calculator.dart File samples/calculator/calculator.dart (right): https://codereview.chromium.org/12218131/diff/2001/samples/calculator/calculator.dart#newcode328 samples/calculator/calculator.dart:328: new Timer(const ...
7 years, 10 months ago (2013-02-13 10:03:07 UTC) #3
Sean Eagan
On 2013/02/13 00:49:06, Emily Fortuna wrote: > Added Florian for switching to using timer. It ...
7 years, 10 months ago (2013-02-13 18:28:09 UTC) #4
floitsch
On 2013/02/13 18:28:09, seaneagan1 wrote: > On 2013/02/13 00:49:06, Emily Fortuna wrote: > > Added ...
7 years, 10 months ago (2013-02-13 18:36:54 UTC) #5
Emily Fortuna
Fixed up! PTAL, Pete. https://codereview.chromium.org/12218131/diff/2001/samples/swarm/App.dart File samples/swarm/App.dart (right): https://codereview.chromium.org/12218131/diff/2001/samples/swarm/App.dart#newcode32 samples/swarm/App.dart:32: new Timer(const Duration(milliseconds:0), () => ...
7 years, 10 months ago (2013-02-13 20:19:44 UTC) #6
blois
7 years, 10 months ago (2013-02-13 20:27:58 UTC) #7
lgtm

Powered by Google App Engine
This is Rietveld 408576698