samples/swarm/App.dart - Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/swarm/App.dart

Issue 12218131: Combine window.setTimeout/setInterval with Timer and Timer.repeating. Also (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samples/swarm/App.dart

diff --git a/samples/swarm/App.dart b/samples/swarm/App.dart

index 2837320a1de5c78028cf056780a3800701ee550e..376a17d3dbd2069a1dc76fe57d43f2015b93c9e3 100644

--- a/samples/swarm/App.dart

+++ b/samples/swarm/App.dart

@@ -27,9 +27,9 @@ class App {

if (document.readyState == "interactive" ||

document.readyState == "complete" ||

document.readyState == "loaded") {

- // We use setTimeout to insure that onLoad is always called in an async

+ // We use a timer to insure that onLoad is always called in an async

// manner even if the document is already loaded.

- window.setTimeout(() => onLoad(), 0);

+ Timer.run(onLoad);

} else {

window.onContentLoaded.listen(

// TODO(sigmund): Consider eliminating the call to "wrap", for

« no previous file with comments | « samples/isolate_html/isolate_sample.dart ('k') | samples/swarm/SwarmViews.dart » ('j') | no next file with comments »