Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1221503004: Reclaim the CreatedFromSnapshot bit and use it to indicate VM Heap object (Closed)

Created:
5 years, 5 months ago by siva
Modified:
5 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

1. Reclaim the CreatedFromSnapshot bit and use the bit to indicate VM heap object. 2. Cleanup calls to set_tags when reading objects from a snapshot. 3. Fixes issue 21816 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/e61f1dc8ce48789166121364bcbc961f45dc38be

Patch Set 1 #

Patch Set 2 : set vm heap bit #

Patch Set 3 : self code review comments #

Patch Set 4 : #

Patch Set 5 : merge-tot #

Patch Set 6 : self-code-review #

Patch Set 7 : cleanup-tag-setting #

Patch Set 8 : self-review-comments #

Total comments: 4

Patch Set 9 : address-code-review-comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -283 lines) Patch
M runtime/vm/dart_api_message.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 8 5 chunks +14 lines, -18 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 8 15 chunks +28 lines, -10 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 3 4 5 6 7 8 6 chunks +10 lines, -10 lines 0 comments Download
M runtime/vm/raw_object.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 2 3 4 5 6 7 8 59 chunks +97 lines, -218 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 2 3 4 5 6 7 chunks +14 lines, -18 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 4 5 6 1 chunk +0 lines, -3 lines 0 comments Download
M tests/isolate/message3_test.dart View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
siva
5 years, 4 months ago (2015-08-07 19:33:36 UTC) #2
regis
LGTM https://codereview.chromium.org/1221503004/diff/140001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1221503004/diff/140001/runtime/vm/raw_object_snapshot.cc#newcode545 runtime/vm/raw_object_snapshot.cc:545: (kind == Snapshot::kFull)); one line https://codereview.chromium.org/1221503004/diff/140001/tests/isolate/isolate.status File tests/isolate/isolate.status ...
5 years, 4 months ago (2015-08-07 19:55:50 UTC) #3
siva
https://codereview.chromium.org/1221503004/diff/140001/runtime/vm/raw_object_snapshot.cc File runtime/vm/raw_object_snapshot.cc (right): https://codereview.chromium.org/1221503004/diff/140001/runtime/vm/raw_object_snapshot.cc#newcode545 runtime/vm/raw_object_snapshot.cc:545: (kind == Snapshot::kFull)); On 2015/08/07 19:55:50, regis wrote: > ...
5 years, 4 months ago (2015-08-07 23:35:09 UTC) #4
siva
5 years, 4 months ago (2015-08-10 18:02:36 UTC) #5
Message was sent while issue was closed. 
Committed patchset #9 (id:160001) manually as
e61f1dc8ce48789166121364bcbc961f45dc38be (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698