runtime/vm/raw_object.cc - Issue 1221503004: Reclaim the CreatedFromSnapshot bit and use it to indicate VM Heap object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object.cc

Issue 1221503004: Reclaim the CreatedFromSnapshot bit and use it to indicate VM Heap object (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address-code-review-comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/raw_object.cc

diff --git a/runtime/vm/raw_object.cc b/runtime/vm/raw_object.cc

index 67f0afc13733f31483bd1737916cfa10678c363d..61c2994484ef82006a9fb5ab05bf6690cf38378f 100644

--- a/runtime/vm/raw_object.cc

+++ b/runtime/vm/raw_object.cc

@@ -18,10 +18,6 @@ namespace dart {

DEFINE_FLAG(bool, validate_overwrite, true, "Verify overwritten fields.");

#endif // DEBUG

-bool RawObject::IsVMHeapObject() const {

- return Dart::vm_isolate()->heap()->Contains(ToAddr(this));

void RawObject::Validate(Isolate* isolate) const {

if (Object::void_class_ == reinterpret_cast<RawClass*>(kHeapObjectTag)) {

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/raw_object_snapshot.cc » ('j') | no next file with comments »