Issue 12212175: Optimize left shift of a constant: compute max value of right that does not overflow into Mint/Bigi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12212175: Optimize left shift of a constant: compute max value of right that does not overflow into Mint/Bigi… (Closed)

Created:
7 years, 10 months ago by srdjan

Modified:
7 years, 9 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Optimize left shift of a constant: compute max value of right that does not overflow into Mint/Bigint. Committed: https://code.google.com/p/dart/source/detail?r=18525

Patch Set 3 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -2 lines)			Patch
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	1 chunk	+29 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	1 chunk	+29 lines, -1 line	0 comments	Download
A	tests/standalone/constant_left_shift_test.dart	View	1 2	1 chunk	+78 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

LGTM. https://codereview.chromium.org/12212175/diff/1/tests/standalone/constant_left_shift_test.dart File tests/standalone/constant_left_shift_test.dart (right): https://codereview.chromium.org/12212175/diff/1/tests/standalone/constant_left_shift_test.dart#newcode25 tests/standalone/constant_left_shift_test.dart:25: } Also add a test case for shiftLeft0(i) ...

7 years, 10 months ago (2013-02-14 17:41:06 UTC) #2

srdjan

7 years, 9 months ago (2013-02-27 18:27:25 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/12212175/diff/1/tests/standalone/constant_lef...
File tests/standalone/constant_left_shift_test.dart (right):

https://codereview.chromium.org/12212175/diff/1/tests/standalone/constant_lef...
tests/standalone/constant_left_shift_test.dart:25: }
On 2013/02/14 17:41:07, Florian Schneider wrote:
> Also add a test case for shiftLeft0(i) where i < 0.

Done.

Expand Messages | Collapse Messages

Issue 12212175: Optimize left shift of a constant: compute max value of right that does not overflow into Mint/Bigi… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages