Optimize left shift of a constant: compute max value of right that does not overflow into Mint/Bigi…

runtime/vm/intermediate_language_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_IA32.
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/intermediate_language.h"
 
 #include "lib/error.h"
@@ skipping 2221 matching lines @@
         __ movl(right, Immediate(kCountLimit));
         __ Bind(&count_ok);
       }
       ASSERT(right == ECX);  // Count must be in ECX
       __ SmiUntag(left);
       __ sarl(left, right);
       __ SmiTag(left);
       break;
     }
     case Token::kSHL: {
+      Range* right_range = this->right()->definition()->range();
+      if (this->left()->BindsToConstant()) {
+        // If left is constant, we know the maximal allowed size for right.
+        const Object& obj = this->left()->BoundConstant();
+        if (obj.IsSmi()) {
+          const intptr_t left_int = Smi::Cast(obj).Value();
+          if (left_int == 0) {
+            __ cmpl(right, Immediate(0));
+            __ j(NEGATIVE, deopt);
+            break;
+          }
+          intptr_t tmp = (left_int > 0) ? left_int : ~left_int;
+          intptr_t max_right = kSmiBits;
+          while ((tmp >>= 1) != 0) {
+            max_right--;
+          }
+          const bool right_needs_check =
+              (right_range == NULL) ||
+              !right_range->IsWithin(0, max_right - 1);
+          if (right_needs_check) {
+            __ cmpl(right,
+              Immediate(reinterpret_cast<int32_t>(Smi::New(max_right))));
+            __ j(ABOVE_EQUAL, deopt);
+          }
+          __ SmiUntag(right);
+          __ shll(left, right);
+          break;
+        }
+      }
       Register temp = locs()->temp(0).reg();
       // Check if count too large for handling it inlined.
       __ movl(temp, left);
-      Range* right_range = this->right()->definition()->range();
       const bool right_needs_check =
           (right_range == NULL) || !right_range->IsWithin(0, (Smi::kBits - 1));
       if (right_needs_check) {
         __ cmpl(right,
           Immediate(reinterpret_cast<int32_t>(Smi::New(Smi::kBits))));
         __ j(ABOVE_EQUAL, deopt);
       }
       ASSERT(right == ECX);  // Count must be in ECX
       __ SmiUntag(right);
       // Overflow test (preserve temp and right);
@@ skipping 1196 matching lines @@
                          PcDescriptors::kOther,
                          locs());
   __ Drop(2);  // Discard type arguments and receiver.
 }
 
 }  // namespace dart
 
 #undef __
 
 #endif  // defined TARGET_ARCH_IA32