Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1220793012: Revert "Fix runtimeType.toString for tear-offs." (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix runtimeType.toString for tear-offs." This reverts commit 87a7ca0720f066c51c6f8884bb93b50183aaabe7. Committed: https://github.com/dart-lang/sdk/commit/24fbfa7f7888b2e93762e8037ec7301a72a4fb48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -67 lines) Patch
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart View 5 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/setup_program_builder.dart View 2 chunks +4 lines, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 2 chunks +6 lines, -25 lines 0 comments Download
D tests/language/runtime_type2_test.dart View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
floitsch
The constructorNameFallback requires the constructor to be a function. I broke this with the work-around ...
5 years, 5 months ago (2015-07-02 11:56:55 UTC) #2
floitsch
5 years, 5 months ago (2015-07-02 11:57:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24fbfa7f7888b2e93762e8037ec7301a72a4fb48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698