Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 1220793012: Revert "Fix runtimeType.toString for tear-offs." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.new_js_emitter.emitter; 5 library dart2js.new_js_emitter.emitter;
6 6
7 import 'package:js_runtime/shared/embedded_names.dart' show 7 import 'package:js_runtime/shared/embedded_names.dart' show
8 JsBuiltin, 8 JsBuiltin,
9 METADATA, 9 METADATA,
10 TYPES; 10 TYPES;
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 125
126 @override 126 @override
127 js.Expression typeAccess(Element element) { 127 js.Expression typeAccess(Element element) {
128 // TODO(floitsch): minify 'ensureResolved'. 128 // TODO(floitsch): minify 'ensureResolved'.
129 // TODO(floitsch): don't emit `ensureResolved` for eager classes. 129 // TODO(floitsch): don't emit `ensureResolved` for eager classes.
130 return js.js('#.ensureResolved()', _globalPropertyAccess(element)); 130 return js.js('#.ensureResolved()', _globalPropertyAccess(element));
131 } 131 }
132 132
133 @override 133 @override
134 js.Template templateForBuiltin(JsBuiltin builtin) { 134 js.Template templateForBuiltin(JsBuiltin builtin) {
135 String typeNameProperty = ModelEmitter.typeNameProperty;
136
135 switch (builtin) { 137 switch (builtin) {
136 case JsBuiltin.dartObjectConstructor: 138 case JsBuiltin.dartObjectConstructor:
137 return js.js.expressionTemplateYielding( 139 return js.js.expressionTemplateYielding(
138 typeAccess(_compiler.objectClass)); 140 typeAccess(_compiler.objectClass));
139 141
140 case JsBuiltin.isCheckPropertyToJsConstructorName: 142 case JsBuiltin.isCheckPropertyToJsConstructorName:
141 int isPrefixLength = namer.operatorIsPrefix.length; 143 int isPrefixLength = namer.operatorIsPrefix.length;
142 return js.js.expressionTemplateFor('#.substring($isPrefixLength)'); 144 return js.js.expressionTemplateFor('#.substring($isPrefixLength)');
143 145
144 case JsBuiltin.isFunctionType: 146 case JsBuiltin.isFunctionType:
145 return _backend.rti.representationGenerator.templateForIsFunctionType; 147 return _backend.rti.representationGenerator.templateForIsFunctionType;
146 148
147 case JsBuiltin.rawRtiToJsConstructorName: 149 case JsBuiltin.rawRtiToJsConstructorName:
148 return js.js.expressionTemplateFor("#.name"); 150 return js.js.expressionTemplateFor("#.$typeNameProperty");
149 151
150 case JsBuiltin.rawRuntimeType: 152 case JsBuiltin.rawRuntimeType:
151 return js.js.expressionTemplateFor("#.constructor"); 153 return js.js.expressionTemplateFor("#.constructor");
152 154
153 case JsBuiltin.createFunctionTypeRti: 155 case JsBuiltin.createFunctionTypeRti:
154 return _backend.rti.representationGenerator 156 return _backend.rti.representationGenerator
155 .templateForCreateFunctionType; 157 .templateForCreateFunctionType;
156 158
157 case JsBuiltin.isSubtype: 159 case JsBuiltin.isSubtype:
158 // TODO(floitsch): move this closer to where is-check properties are 160 // TODO(floitsch): move this closer to where is-check properties are
159 // built. 161 // built.
160 String isPrefix = namer.operatorIsPrefix; 162 String isPrefix = namer.operatorIsPrefix;
161 return js.js.expressionTemplateFor("('$isPrefix' + #) in #.prototype"); 163 return js.js.expressionTemplateFor("('$isPrefix' + #) in #.prototype");
162 164
163 case JsBuiltin.isGivenTypeRti: 165 case JsBuiltin.isGivenTypeRti:
164 return js.js.expressionTemplateFor('#.name === #'); 166 return js.js.expressionTemplateFor('#.$typeNameProperty === #');
165 167
166 case JsBuiltin.getMetadata: 168 case JsBuiltin.getMetadata:
167 return _emitter.templateForReadMetadata; 169 return _emitter.templateForReadMetadata;
168 170
169 case JsBuiltin.getType: 171 case JsBuiltin.getType:
170 return _emitter.templateForReadType; 172 return _emitter.templateForReadType;
171 173
172 default: 174 default:
173 _compiler.internalError(NO_LOCATION_SPANNABLE, 175 _compiler.internalError(NO_LOCATION_SPANNABLE,
174 "Unhandled Builtin: $builtin"); 176 "Unhandled Builtin: $builtin");
175 return null; 177 return null;
176 } 178 }
177 } 179 }
178 180
179 @override 181 @override
180 void invalidateCaches() { 182 void invalidateCaches() {
181 } 183 }
182 } 184 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/new_emitter/model_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698