dart2js: Fix regression in minified names for one shot interceptors.

dart2js: Fix regression in minified names for one shot interceptors.

R=sra@google.com
BUG= http://dartbug.com/23731

Committed: https://github.com/dart-lang/sdk/commit/964afc05237b9e86ff08043ac726ce421d4773d4

[herhut, 2015-06-30 18:36:45]

As requested, here is a factored out change from the bigger cl.

[sra1, 2015-07-01 01:21:39]

LGTM fix indentation fix

https://codereview.chromium.org/1220793006/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/minify_namer.dart (right):

https://codereview.chromium.org/1220793006/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/minify_namer.dart:267: :
privateName(selector.memberName);
Format like this:

   String root = selector.isOperator
       ? operatorNameToIdentifier(selector.name)
       : privateName(selector.memberName);

https://codereview.chromium.org/1220793006/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/minify_namer.dart:272: String fullName =
"\$intercepted$prefix\$$root$arity\$$suffix";
Do we need '$intercepted'?

[herhut, 2015-07-01 08:57:47]

https://codereview.chromium.org/1220793006/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/minify_namer.dart (right):

https://codereview.chromium.org/1220793006/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/minify_namer.dart:267: :
privateName(selector.memberName);
On 2015/07/01 01:21:38, sra1 wrote:
> Format like this:
> 
>    String root = selector.isOperator
>        ? operatorNameToIdentifier(selector.name)
>        : privateName(selector.memberName);

Done.

https://codereview.chromium.org/1220793006/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/minify_namer.dart:272: String fullName =
"\$intercepted$prefix\$$root$arity\$$suffix";
On 2015/07/01 01:21:38, sra1 wrote:
> Do we need '$intercepted'?

So the generated name is only used as a unqiue key for allocation of minified
names. Using a prefix that starts with $something$ makes sure that the key does
not clash with an actual name.

I like to use descriptive prefixes in keys to make it easier to track down name
allocations.

[herhut, 2015-07-01 09:01:10]

Committed patchset #2 (id:20001) manually as
964afc05237b9e86ff08043ac726ce421d4773d4 (presubmit successful).