dart2js: Fix regression in minified names for one shot interceptors.

pkg/compiler/lib/src/js_backend/minify_namer.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of js_backend;
 
 /**
  * Assigns JavaScript identifiers to Dart variables, class-names and members.
  */
-class MinifyNamer extends Namer with _MinifiedFieldNamer {
+class MinifyNamer extends Namer with _MinifiedFieldNamer,
+    _MinifiedOneShotInterceptorNamer {
   MinifyNamer(Compiler compiler) : super(compiler) {
     reserveBackendNames();
     fieldRegistry = new _FieldNamingRegistry(this);
   }
 
   _FieldNamingRegistry fieldRegistry;
 
   String get isolateName => 'I';
   String get isolatePropertiesName => 'p';
   bool get shouldMinify => true;
@@ skipping 227 matching lines @@
   @override
   jsAst.Name instanceFieldPropertyName(Element element) {
     jsAst.Name proposed = _minifiedInstanceFieldPropertyName(element);
     if (proposed != null) {
       return proposed;
     }
     return super.instanceFieldPropertyName(element);
   }
 }
 
+
+abstract class _MinifiedOneShotInterceptorNamer implements Namer {
+  /// Property name used for the one-shot interceptor method for the given
+  /// [selector] and return-type specialization.
+  @override
+  jsAst.Name nameForGetOneShotInterceptor(Selector selector,
+      Iterable<ClassElement> classes) {
+    String root = selector.isOperator ? operatorNameToIdentifier(selector.name)
+    : privateName(selector.memberName);

[sra1, 2015/07/01 01:21:38]

Format like this:

   String root = selector.isOperator
       ? operatorNameToIdentifier(selector.name)
       : privateName(selector.memberName);

[herhut, 2015/07/01 08:57:47]

Done.

+    String prefix = selector.isGetter ? r"$get"
+    : selector.isSetter ? r"$set" : "";
+    String arity = selector.isCall ? "${selector.argumentCount}" : "";
+    String suffix = suffixForGetInterceptor(classes);
+    String fullName = "\$intercepted$prefix\$$root$arity\$$suffix";

[sra1, 2015/07/01 01:21:38]

Do we need '$intercepted'?

[herhut, 2015/07/01 08:57:46]

So the generated name is only used as a unqiue key for allocation of minified
names. Using a prefix that starts with $something$ makes sure that the key does
not clash with an actual name.

I like to use descriptive prefixes in keys to make it easier to track down name
allocations.

+    return _disambiguateInternalGlobal(fullName);
+  }
+}