Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1220743004: Split BuildSourceClosuresTask into two tasks; remove unnecessary computation. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split BuildSourceClosuresTask into two tasks; remove unnecessary computation. This splits BuildSourceClosuresTask into BuildSourceExportClosureTask, which produces EXPORT_SOURCE_CLOSURE, and BuildSourceImportExportClosureTask, which produces IMPORT_EXPORT_SOURCE_CLOSURE. IMPORT_SOURCE_CLOSURE is no longer computed, since it was not being used. This should reduce the amount of analysis work that needs to be rerun before we can produce code completions, since we will no longer have so recompute the import/export source closure (which could potentially need recomputation for a large number of files) until just prior to ResolveUnitReferencesTask, which in theory doesn't need to run in order to produce code completions. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/21b65e700bb72965f5314e779edcb0c676841e66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -92 lines) Patch
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 5 chunks +58 lines, -33 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 9 chunks +15 lines, -58 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-06-29 16:49:18 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-06-29 16:58:37 UTC) #3
Paul Berry
5 years, 5 months ago (2015-06-29 17:13:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
21b65e700bb72965f5314e779edcb0c676841e66 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698