Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: pkg/analyzer/lib/src/plugin/engine_plugin.dart

Issue 1220743004: Split BuildSourceClosuresTask into two tasks; remove unnecessary computation. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library analyzer.src.plugin.engine_plugin; 5 library analyzer.src.plugin.engine_plugin;
6 6
7 import 'package:analyzer/plugin/task.dart'; 7 import 'package:analyzer/plugin/task.dart';
8 import 'package:analyzer/src/task/dart.dart'; 8 import 'package:analyzer/src/task/dart.dart';
9 import 'package:analyzer/src/task/general.dart'; 9 import 'package:analyzer/src/task/general.dart';
10 import 'package:analyzer/src/task/html.dart'; 10 import 'package:analyzer/src/task/html.dart';
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 // Register Dart tasks. 63 // Register Dart tasks.
64 // 64 //
65 registerExtension(taskId, BuildClassConstructorsTask.DESCRIPTOR); 65 registerExtension(taskId, BuildClassConstructorsTask.DESCRIPTOR);
66 registerExtension(taskId, BuildCompilationUnitElementTask.DESCRIPTOR); 66 registerExtension(taskId, BuildCompilationUnitElementTask.DESCRIPTOR);
67 registerExtension(taskId, BuildDirectiveElementsTask.DESCRIPTOR); 67 registerExtension(taskId, BuildDirectiveElementsTask.DESCRIPTOR);
68 registerExtension(taskId, BuildEnumMemberElementsTask.DESCRIPTOR); 68 registerExtension(taskId, BuildEnumMemberElementsTask.DESCRIPTOR);
69 registerExtension(taskId, BuildExportNamespaceTask.DESCRIPTOR); 69 registerExtension(taskId, BuildExportNamespaceTask.DESCRIPTOR);
70 registerExtension(taskId, BuildLibraryConstructorsTask.DESCRIPTOR); 70 registerExtension(taskId, BuildLibraryConstructorsTask.DESCRIPTOR);
71 registerExtension(taskId, BuildLibraryElementTask.DESCRIPTOR); 71 registerExtension(taskId, BuildLibraryElementTask.DESCRIPTOR);
72 registerExtension(taskId, BuildPublicNamespaceTask.DESCRIPTOR); 72 registerExtension(taskId, BuildPublicNamespaceTask.DESCRIPTOR);
73 registerExtension(taskId, BuildSourceClosuresTask.DESCRIPTOR); 73 registerExtension(taskId, BuildSourceExportClosureTask.DESCRIPTOR);
74 registerExtension(taskId, BuildSourceImportExportClosureTask.DESCRIPTOR);
74 registerExtension(taskId, BuildTypeProviderTask.DESCRIPTOR); 75 registerExtension(taskId, BuildTypeProviderTask.DESCRIPTOR);
75 registerExtension(taskId, ComputeConstantDependenciesTask.DESCRIPTOR); 76 registerExtension(taskId, ComputeConstantDependenciesTask.DESCRIPTOR);
76 registerExtension(taskId, ComputeConstantValueTask.DESCRIPTOR); 77 registerExtension(taskId, ComputeConstantValueTask.DESCRIPTOR);
77 registerExtension(taskId, ContainingLibrariesTask.DESCRIPTOR); 78 registerExtension(taskId, ContainingLibrariesTask.DESCRIPTOR);
78 registerExtension(taskId, DartErrorsTask.DESCRIPTOR); 79 registerExtension(taskId, DartErrorsTask.DESCRIPTOR);
79 registerExtension(taskId, EvaluateUnitConstantsTask.DESCRIPTOR); 80 registerExtension(taskId, EvaluateUnitConstantsTask.DESCRIPTOR);
80 registerExtension(taskId, GatherUsedImportedElementsTask.DESCRIPTOR); 81 registerExtension(taskId, GatherUsedImportedElementsTask.DESCRIPTOR);
81 registerExtension(taskId, GatherUsedLocalElementsTask.DESCRIPTOR); 82 registerExtension(taskId, GatherUsedLocalElementsTask.DESCRIPTOR);
82 registerExtension(taskId, GenerateHintsTask.DESCRIPTOR); 83 registerExtension(taskId, GenerateHintsTask.DESCRIPTOR);
83 registerExtension(taskId, LibraryErrorsReadyTask.DESCRIPTOR); 84 registerExtension(taskId, LibraryErrorsReadyTask.DESCRIPTOR);
(...skipping 18 matching lines...) Expand all
102 * Validate the given extension by throwing an [ExtensionError] if it is not a 103 * Validate the given extension by throwing an [ExtensionError] if it is not a
103 * valid domain. 104 * valid domain.
104 */ 105 */
105 void _validateTaskExtension(Object extension) { 106 void _validateTaskExtension(Object extension) {
106 if (extension is! TaskDescriptor) { 107 if (extension is! TaskDescriptor) {
107 String id = taskExtensionPoint.uniqueIdentifier; 108 String id = taskExtensionPoint.uniqueIdentifier;
108 throw new ExtensionError('Extensions to $id must be a TaskDescriptor'); 109 throw new ExtensionError('Extensions to $id must be a TaskDescriptor');
109 } 110 }
110 } 111 }
111 } 112 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698