Chromium Code Reviews

Issue 1220223008: Fix an edge case in the dependency computer. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org, Bob Nystrom
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix an edge case in the dependency computer. When a package both transformed itself and had a dev transformer (that is, a transformer that only runs on non-public files), *and* that package's self-transformed code was imported by another transformer, the dependency computer could return the dev transformer in its results. Closes #1290 Closes #1291 R=kevmoo@google.com Committed: https://github.com/dart-lang/pub/commit/052756a1ed0832dea23743ec22c2165df45ba3c7

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+47 lines, -4 lines)
M lib/src/barback/dependency_computer.dart View 3 chunks +11 lines, -4 lines 0 comments
M test/dependency_computer/dev_transformers_test.dart View 1 chunk +36 lines, -0 lines 0 comments

Messages

Total messages: 4 (1 generated)
nweiz
5 years, 5 months ago (2015-07-07 00:06:41 UTC) #2
kevmoo
lgtm
5 years, 5 months ago (2015-07-07 00:11:32 UTC) #3
nweiz
5 years, 5 months ago (2015-07-07 00:12:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
052756a1ed0832dea23743ec22c2165df45ba3c7 (presubmit successful).

Powered by Google App Engine