Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: test/dependency_computer/dev_transformers_test.dart

Issue 1220223008: Fix an edge case in the dependency computer. (Closed) Base URL: git@github.com:dart-lang/pub.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/dependency_computer/dev_transformers_test.dart
diff --git a/test/dependency_computer/dev_transformers_test.dart b/test/dependency_computer/dev_transformers_test.dart
index d5a4c9a1f20267825b3e6a106bdcf9c17c4a2165..56ad5b2e5ddf824fde01fe863d0b03c17ccdf603 100644
--- a/test/dependency_computer/dev_transformers_test.dart
+++ b/test/dependency_computer/dev_transformers_test.dart
@@ -88,4 +88,40 @@ void main() {
expectDependencies({"foo": []});
});
+
+ // Regression test for #1291
+ integration("doesn't return a dependency's transformer that can't run on lib "
+ "when the app's transformer imports the dependency's", () {
+ d.dir(appPath, [
+ d.pubspec({
+ "name": "myapp",
+ "dependencies": {"foo": {"path": "../foo"}},
+ "transformers": ["myapp"]
+ }),
+ d.dir("lib", [
+ d.file("myapp.dart", transformer(['package:foo/foo.dart']))
+ ])
+ ]).create();
+
+ d.dir("foo", [
+ d.pubspec({
+ "name": "foo",
+ "version": "1.0.0",
+ "transformers": [
+ ["foo/bar"],
+ [{"foo": {"\$include": "test/foo_test.dart"}}]
+ ]
+ }),
+ d.dir("lib", [
+ d.file("foo.dart", transformer()),
+ d.file("bar.dart", transformer())
+ ]),
+ d.dir("test", [d.file("foo_test.dart", "")])
+ ]).create();
+
+ expectDependencies({
+ 'foo/bar': [],
+ 'myapp': ['foo/bar']
+ });
+ });
}
« no previous file with comments | « lib/src/barback/dependency_computer.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698