Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1220193009: Migrate most uses of Isolate::current_zone to Thread::zone. (Closed)

Created:
5 years, 5 months ago by koda
Modified:
5 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrate most uses of Isolate::current_zone to Thread::zone. After https://codereview.chromium.org/1204303003/ is submitted, the last remaining uses can go. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/c089a152ac20b63386a8827c482bd9f57975c309

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -133 lines) Patch
M runtime/vm/allocation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bigint_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bitmap.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bitmap.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/coverage.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/disassembler_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/double_conversion.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/growable_array.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/hash_map.h View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/il_printer.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/locations.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 60 chunks +67 lines, -66 lines 0 comments Download
M runtime/vm/os_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/os_linux.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/service_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stack_frame_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/timeline.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
koda
5 years, 5 months ago (2015-07-07 18:00:08 UTC) #2
siva
lgtm
5 years, 5 months ago (2015-07-08 16:16:59 UTC) #3
koda
5 years, 5 months ago (2015-07-08 16:59:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c089a152ac20b63386a8827c482bd9f57975c309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698