runtime/vm/debugger.cc - Issue 1220193009: Migrate most uses of Isolate::current_zone to Thread::zone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.cc

Issue 1220193009: Migrate most uses of Isolate::current_zone to Thread::zone. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/debugger.cc

diff --git a/runtime/vm/debugger.cc b/runtime/vm/debugger.cc

index 0364ac8281541cec2f5a0e26e9d6976a441c0082..6f761b6d4db0dffc6a6d5ce16823bc161098896a 100644

--- a/runtime/vm/debugger.cc

+++ b/runtime/vm/debugger.cc

@@ -404,7 +404,7 @@ const char* Debugger::QualifiedFunctionName(const Function& func) {

func_class.IsTopLevel() ? "" : ".",

func_name.ToCString());

len++; // String terminator.

- char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);

+ char* chars = Thread::Current()->zone()->Alloc<char>(len);

OS::SNPrint(chars, len, kFormat,

func_class.IsTopLevel() ? "" : class_name.ToCString(),

func_class.IsTopLevel() ? "" : ".",

@@ -1020,7 +1020,7 @@ const char* ActivationFrame::ToCString() {

const String& url = String::Handle(SourceUrl());

intptr_t line = LineNumber();

const char* func_name = Debugger::QualifiedFunctionName(function());

- return Isolate::Current()->current_zone()->

+ return Thread::Current()->zone()->

PrintToString("[ Frame pc(0x%" Px ") fp(0x%" Px ") sp(0x%" Px ")\n"

"\tfunction = %s\n"

"\turl = %s\n"

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger_test.cc » ('j') | no next file with comments »