Issue 12188017: Fixing element_types_test/supported_object

Issue 12188017: Fixing element_types_test/supported_object (Closed)

Created:
7 years, 10 months ago by blois

Modified:
7 years, 10 months ago

Reviewers:
ngeoffray, sra1

CC:
reviews_dartlang.org, ngeoffray

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixing element_types_test/supported_object Typo had it checking meter instead which was masking a FF failure. BUG=8293 Committed: https://code.google.com/p/dart/source/detail?r=18107

Patch Set 2 : #

Total comments: 3

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+0 lines, -1 line	2 comments	Download
M	tests/html/element_types_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/html.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

Updated with fix to createElement_tag to indicate that it can return a function as well.

7 years, 10 months ago (2013-02-04 19:57:02 UTC) #2

ngeoffray

DBC https://codereview.chromium.org/12188017/diff/6001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12188017/diff/6001/sdk/lib/html/dartium/html_dartium.dart#oldcode19940 sdk/lib/html/dartium/html_dartium.dart:19940: @SupportedBrowser(SupportedBrowser.SAFARI) Why do you need these type annotations ...

7 years, 10 months ago (2013-02-04 20:06:02 UTC) #3

blois

https://codereview.chromium.org/12188017/diff/6001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (left): https://codereview.chromium.org/12188017/diff/6001/sdk/lib/html/dartium/html_dartium.dart#oldcode19940 sdk/lib/html/dartium/html_dartium.dart:19940: @SupportedBrowser(SupportedBrowser.SAFARI) On 2013/02/04 20:06:02, ngeoffray wrote: > Why do ...

7 years, 10 months ago (2013-02-04 20:38:16 UTC) #4

sra1

7 years, 10 months ago (2013-02-04 22:46:37 UTC) #5

lgtm

https://codereview.chromium.org/12188017/diff/6001/tools/dom/templates/html/i...
File tools/dom/templates/html/impl/impl_Element.darttemplate (right):

https://codereview.chromium.org/12188017/diff/6001/tools/dom/templates/html/i...
tools/dom/templates/html/impl/impl_Element.darttemplate:1031:
JS('Element|Function', 'document.createElement(#)', tag);
I'd write

// Firefox may return a JavaScript function which is no really any Dart type.
// =Object is the closes approximation to this.
JS('Element|=Object', ...)

Expand Messages | Collapse Messages