Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: tools/dom/templates/html/impl/impl_Element.darttemplate

Issue 12188017: Fixing element_types_test/supported_object (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/html/dartium/html_dartium.dart ('K') | « tools/dom/scripts/generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_Element.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate
index 58c63f52d6e535a4761bafab31b82fd3f175242f..a93f8b909a4785561287cce3aed7a9cf6d545bc0 100644
--- a/tools/dom/templates/html/impl/impl_Element.darttemplate
+++ b/tools/dom/templates/html/impl/impl_Element.darttemplate
@@ -1028,7 +1028,7 @@ $if DART2JS
// Optimization to improve performance until the dart2js compiler inlines this
// method.
static dynamic createElement_tag(String tag) =>
- JS('Element', 'document.createElement(#)', tag);
+ JS('Element|Function', 'document.createElement(#)', tag);
sra1 2013/02/04 22:46:37 I'd write // Firefox may return a JavaScript func
$else
static Element createElement_tag(String tag) =>
document.$dom_createElement(tag);
« sdk/lib/html/dartium/html_dartium.dart ('K') | « tools/dom/scripts/generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698