Issue 1218503003: Don't remove ResultData(s) for incrementally updated results.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218503003: Don't remove ResultData(s) for incrementally updated results. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Don't remove ResultData(s) for incrementally updated results. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b2ef3f19342bbd6be311f3f184e4b34554bb74be

Patch Set 2 : Disable 'limitInvalidationInTaskModel' #

Total comments: 1

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -77 lines)			Patch
M	pkg/analyzer/lib/src/context/cache.dart	View	2 chunks	+26 lines, -13 lines	0 comments	Download
M	pkg/analyzer/lib/src/context/context.dart	View	1 chunk	+24 lines, -15 lines	1 comment	Download
M	pkg/analyzer/lib/src/task/dart.dart	View	3 chunks	+47 lines, -29 lines	0 comments	Download
M	pkg/analyzer/test/src/context/context_test.dart	View	2 chunks	+123 lines, -20 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1218503003/diff/20001/pkg/analyzer/lib/src/context/context.dart File pkg/analyzer/lib/src/context/context.dart (right): https://codereview.chromium.org/1218503003/diff/20001/pkg/analyzer/lib/src/context/context.dart#newcode1747 pkg/analyzer/lib/src/context/context.dart:1747: print( Remove or comment out debugging statement?

5 years, 6 months ago (2015-06-26 16:12:07 UTC) #2

scheglov

5 years, 6 months ago (2015-06-26 16:39:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b2ef3f19342bbd6be311f3f184e4b34554bb74be (presubmit successful).

Expand Messages | Collapse Messages

Issue 1218503003: Don't remove ResultData(s) for incrementally updated results. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Disable 'limitInvalidationInTaskModel' #

Messages