Don't remove ResultData(s) for incrementally updated results.

pkg/analyzer/lib/src/context/cache.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.context.cache;
 
 import 'dart:async';
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/engine.dart'
@@ skipping 474 matching lines @@
   /**
    * Return the value of the flag with the given [index].
    */
   bool _getFlag(int index) => BooleanArray.get(_flags, index);
 
   /**
    * Invalidate the result represented by the given [descriptor] and propagate
    * invalidation to other results that depend on it.
    */
   void _invalidate(ResultDescriptor descriptor, Delta delta) {
-    if (delta != null &&
-        !delta.affects(_partition.context, target, descriptor)) {
-//      print('not-invalidate $descriptor for $target');
-      return;
+    DeltaResult deltaResult = null;
+    if (delta != null) {
+      deltaResult = delta.validate(_partition.context, target, descriptor);
+      if (deltaResult == DeltaResult.STOP) {
+//        print('not-invalidate $descriptor for $target');
+        return;
+      }
     }
 //    print('invalidate $descriptor for $target');
-    ResultData thisData = _resultMap.remove(descriptor);
+    ResultData thisData;
+    if (deltaResult == null || deltaResult == DeltaResult.INVALIDATE) {
+      thisData = _resultMap.remove(descriptor);
+    }
+    if (deltaResult == DeltaResult.KEEP_CONTINUE) {
+      thisData = _resultMap[descriptor];
+    }
     if (thisData == null) {
       return;
     }
     // Stop depending on other results.
     TargetedResult thisResult = new TargetedResult(target, descriptor);
-    thisData.dependedOnResults.forEach((TargetedResult dependedOnResult) {
+    for (TargetedResult dependedOnResult in thisData.dependedOnResults) {
       ResultData data = _partition._getDataFor(dependedOnResult, orNull: true);
       if (data != null) {
         data.dependentResults.remove(thisResult);
       }
-    });
+    }
     // Invalidate results that depend on this result.
-    Set<TargetedResult> dependentResults = thisData.dependentResults;
-    thisData.dependentResults = new Set<TargetedResult>();
-    dependentResults.forEach((TargetedResult dependentResult) {
+    List<TargetedResult> dependentResults = thisData.dependentResults.toList();
+    for (TargetedResult dependentResult in dependentResults) {
       CacheEntry entry = _partition.get(dependentResult.target);
       if (entry != null) {
         entry._invalidate(dependentResult.result, delta);
       }
-    });
+    }
     // If empty, remove the entry altogether.
     if (_resultMap.isEmpty) {
       _partition._targetMap.remove(target);
       _partition._removeIfSource(target);
     }
     // Notify controller.
     _partition._onResultInvalidated
         .add(new InvalidatedResult(this, descriptor));
   }
 
@@ skipping 437 matching lines @@
  */
 class Delta {
   final Source source;
 
   Delta(this.source);
 
   /**
    * Check whether this delta affects the result described by the given
    * [descriptor] and [target].
    */
-  bool affects(InternalAnalysisContext context, AnalysisTarget target,
+  DeltaResult validate(InternalAnalysisContext context, AnalysisTarget target,
       ResultDescriptor descriptor) {
-    return true;
+    return DeltaResult.INVALIDATE;
   }
 }
 
 /**
+ * The possible results of validating analysis results againt a [Delta].
+ */
+enum DeltaResult { INVALIDATE, KEEP_CONTINUE, STOP }
+
+/**
  * [InvalidatedResult] describes an invalidated result.
  */
 class InvalidatedResult {
   /**
    * The target in which the result was invalidated.
    */
   final CacheEntry entry;
 
   /**
    * The descriptor of the result which was invalidated.
@@ skipping 142 matching lines @@
   void resultAccessed(TargetedResult result) {}
 
   @override
   List<TargetedResult> resultStored(TargetedResult newResult, newValue) {
     return TargetedResult.EMPTY_LIST;
   }
 
   @override
   void targetRemoved(AnalysisTarget target) {}
 }