Issue 1218183007: Change navigation regions generation for constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1218183007: Change navigation regions generation for constructors. (Closed)

Created:
5 years, 5 months ago by scheglov

Modified:
5 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Change navigation regions generation for constructors. In IDEA we use navigation regions for resolution. And so far all navigation regions are for separate identifiers. This CL splits single regions like "new A.named()" into separate "A" and "named" regions. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/7e194d8fb5960f6249e87b5648dc67c1e928cc64

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -20 lines)			Patch
	M	pkg/analysis_server/lib/src/computer/computer_navigation.dart	View		1 chunk	+7 lines, -9 lines	0 comments	Download
	M	pkg/analysis_server/test/analysis/notification_navigation_test.dart	View		9 chunks	+23 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

5 years, 5 months ago (2015-07-06 18:27:25 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7e194d8fb5960f6249e87b5648dc67c1e928cc64 (presubmit successful).