Issue 12177007: Make mode argument optional for IDB transaction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12177007: Make mode argument optional for IDB transaction. (Closed)

Created:
7 years, 10 months ago by Emily Fortuna

Modified:
7 years, 10 months ago

Reviewers:
sra1, blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make mode argument optional for IDB transaction. BUG= Committed: https://code.google.com/p/dart/source/detail?r=18076

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/html/indexeddb_1_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for http://code.google.com/p/dart/issues/detail?id=6444

7 years, 10 months ago (2013-02-03 22:49:28 UTC) #1

blois

7 years, 10 months ago (2013-02-04 18:21:53 UTC) #2

lgtm

https://codereview.chromium.org/12177007/diff/1/tools/dom/templates/html/dart...
File tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate (right):

https://codereview.chromium.org/12177007/diff/1/tools/dom/templates/html/dart...
tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate:9: Transaction
transaction(storeName_OR_storeNames, {String mode: 'readonly'}) {
I would move the default value out of here- in general they are problematic as
they impede overrides. I believe the practical guidance has been to only use
defaults for bools.

Then use an if (mode != null) check to default it (also moving away from ?
operator).

Expand Messages | Collapse Messages