Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: tools/dom/templates/html/dart2js/impl_IDBDatabase.darttemplate

Issue 12177007: Make mode argument optional for IDB transaction. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tests/html/indexeddb_1_test.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of $LIBRARYNAME; 5 part of $LIBRARYNAME;
6 6
7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC { 7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
8 8
9 Transaction transaction(storeName_OR_storeNames, String mode) { 9 Transaction transaction(storeName_OR_storeNames, {String mode}) {
10 if (mode == null) mode = 'readonly';
10 if (mode != 'readonly' && mode != 'readwrite') { 11 if (mode != 'readonly' && mode != 'readwrite') {
11 throw new ArgumentError(mode); 12 throw new ArgumentError(mode);
12 } 13 }
13 14
14 // TODO(sra): Ensure storeName_OR_storeNames is a string or List<String>, 15 // TODO(sra): Ensure storeName_OR_storeNames is a string or List<String>,
15 // and copy to JavaScript array if necessary. 16 // and copy to JavaScript array if necessary.
16 17
17 // Try and create a transaction with a string mode. Browsers that expect a 18 // Try and create a transaction with a string mode. Browsers that expect a
18 // numeric mode tend to convert the string into a number. This fails 19 // numeric mode tend to convert the string into a number. This fails
19 // silently, resulting in zero ('readonly'). 20 // silently, resulting in zero ('readonly').
20 return _transaction(storeName_OR_storeNames, mode); 21 return _transaction(storeName_OR_storeNames, mode);
21 } 22 }
22 23
23 @JSName('transaction') 24 @JSName('transaction')
24 Transaction _transaction(stores, mode) native; 25 Transaction _transaction(stores, mode) native;
25 26
26 $!MEMBERS} 27 $!MEMBERS}
OLDNEW
« no previous file with comments | « tests/html/indexeddb_1_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698