Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1217593006: Quick Assist for converting field formal parameters into normal parameters and initializers. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Quick Assist for converting field formal parameters into normal parameters and initializers. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0bb5179b844e71fd408ea91db5f02483ce31a910

Patch Set 1 #

Patch Set 2 : Tweak for untyped fields. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 2 chunks +33 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-07-06 18:11:56 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-06 18:13:30 UTC) #2
scheglov
5 years, 5 months ago (2015-07-06 18:19:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0bb5179b844e71fd408ea91db5f02483ce31a910 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698